Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(walled_garden): register plugin hook during init #11819

Merged
merged 1 commit into from Mar 21, 2018
Merged

fix(walled_garden): register plugin hook during init #11819

merged 1 commit into from Mar 21, 2018

Conversation

jeabakker
Copy link
Member

@jeabakker jeabakker commented Mar 21, 2018 •
edited

This way others can unregister the hook easier

fixes #11811

Test:

  • walled garden has no public access
  • able to unregister hook from plugin

@jeabakker
fix(walled_garden): register plugin hook during init
f9880cb 
This way others can unregister the hook easier

fixes Elgg#11811
@jdalsem
Copy link
Member

jdalsem commented Mar 21, 2018

have you tested walled garden still has no public access? And did you also test that you can now unregister the hook?

@jeabakker
Copy link
Member Author

yep ;)

@jdalsem jdalsem merged commit d14ef5e into Elgg:2.3 Mar 21, 2018
@jeabakker jeabakker deleted the walled-garden-public-access branch July 20, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeabakker @jdalsem