Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aalborg_theme): removes unwanted margins #6892

Merged
merged 1 commit into from Jun 9, 2014
Merged

fix(aalborg_theme): removes unwanted margins #6892

merged 1 commit into from Jun 9, 2014

Conversation

PerJensen
Copy link
Contributor

No description provided.

@mrclay
Copy link
Member

mrclay commented May 31, 2014

I'd like more useful description in commit msg. What's the motivation? What does it fix?

@ewinslow
Copy link
Contributor

ewinslow commented Jun 9, 2014

@PerJensen can you add more detailed info to this commit? What was it like before? Why is the new way better?

@PerJensen
Copy link
Contributor Author

Maybe with a little help!

It removes left and right margin from bashboard blurb and right margin from content lists like pages, blogs and from wire posts.

Similar margins is already removed in aalborg_theme, so these margins is a bug

dashboard-blurb

pages-list

@ewinslow
Copy link
Contributor

ewinslow commented Jun 9, 2014

Sweet. I think if you just put that comment into the commit message, we're good to go.

@PerJensen
Copy link
Contributor Author

Ohhh my. Remember messing things up last I did something similar! Can I add the text here, where it says No description provided?

@ewinslow
Copy link
Contributor

ewinslow commented Jun 9, 2014

No. It should be in the git commit message so that people can easily get to
the explanation from the commit link in the change log.

We have a contributor guide for this. I encourage you to read it and give
feedback on what's clear. It's going to be pretty common to need to edit
commits I imagine :)
On Jun 8, 2014 9:55 PM, "Per Jensen" notifications@github.com wrote:

Ohhh my. Remember messing things up last I did something similar! Can I
add the text here, where it says No description provided?


Reply to this email directly or view it on GitHub
#6892 (comment).

@PerJensen
Copy link
Contributor Author

@ewinslow Is this okay?

@ewinslow
Copy link
Contributor

ewinslow commented Jun 9, 2014

"bashboard blurb" => "dashboard blurb" and we're good to go.

Removes left and right margin from dashboard blurb and right margin from content lists like pages, blogs and from wire posts.
@PerJensen
Copy link
Contributor Author

I think it's finally there.

ewinslow added a commit that referenced this pull request Jun 9, 2014
fix(aalborg_theme): removes unwanted  margins
@ewinslow ewinslow merged commit ad466de into Elgg:1.9 Jun 9, 2014
@PerJensen PerJensen deleted the aalborg_css branch August 7, 2014 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants