chore(pages): edit form no longer uses global config for form elements #7346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pages edit form used a global config for it's form elements. This was very confusing and not as extendable as expected. fixes: Elgg#4490
| /** | ||
| * This view outputs the deprecated way of extending the pages form elements. | ||
| * | ||
| * DON'T extend or overrule this view as it will be removed in Elgg 1.11 |
There was a problem hiding this comment.
Cannot be removed until 2.0.
There was a problem hiding this comment.
Semver allows us to remove API only in major versions.
|
I don't see how we can accept this change. The fact that it was configurable is part of the API (poorly designed, I'll admit, but API nonetheless). That makes this a breaking change which we can't accept for 1.x no matter how small the breakage is perceived to be. |
|
Am I missing something? |
|
Also I'd like to move to more configuration like this for forms, actually, not less. It just needs to be better designed configuration. Forms have so much repeated code it's maddening. |
|
Definitely can't do for 1.x, but see my comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pages edit form used a global config for it's form elements. This
was very confusing and not as extendable as expected.
fixes: #4490