feature(php): Require PHP 5.4+ #7475
Conversation
PHP 5.3 is currently end-of-life and 5.4 will have only ~1 year of security patches when Elgg 1.10 is scheduled to be released. Fixes Elgg#7090
|
Note that one feature in particular I'd really like to have for #7474 is lexical |
|
@brettp, @mrclay, @hypeJunction -- WDYT? |
|
Fine by me. I say we give a fair warning to the community, make a blog post or something, so people can work with their hosting providers to upgrade the PHP. |
|
Sounds good. I'm happy to do it once this goes in. I believe this is a no-brainer, but since it's such a fundamental requirement change and we never really got closure when this was last discussed, I think I'd like to see 3 LGTMs (4 including me) and no blockers before pulling it in. |
|
Lgtm |
|
LGTM. Should we perhaps short circuit the installer in version is lower? |
|
I already updated the min version check in the installer which should issue a visible warning. Also composer so complain about any attempt to install on php < 5.4. What else did you have in mind? |
|
@Elgg/owners @Elgg/contributors ... Just to make sure everyone is aware in case notifications aren't turned on or something. |
|
LGTM |
1 similar comment
|
LGTM |
|
OK! We've got the LGTMs. I will write the blog post and merge this once that is done unless anyone objects... |
|
why are some requirements 5.6? |
|
Those are only tests and sample manifest. I think there's no harm in promoting even newer PHP version in docs. |
|
They are not requirements. Those are just example plugin manifests. Honestly, I made them 5.6 so we wouldn't have to change them for a while :). But I think it also serves to show that you can require a higher version of php for your plugins than core |
|
ok then lgtm ;) |
feature(php): Require PHP 5.4+
PHP 5.3 is currently end-of-life and 5.4 will have only ~1 year of security patches
when Elgg 1.10 is scheduled to be released.
Fixes #7090