security(passwords): switches password hashing to password_hash() #7594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| notify_user($user->guid, | ||
| elgg_get_site_entity()->guid, | ||
| _elgg_services()->translator->translate("email:$ns:subject"), | ||
| _elgg_services()->translator->translate("email:$ns:body", array($user->username, $password)), |
There was a problem hiding this comment.
Pass in user's language as the third parameter to the translate() calls.
There was a problem hiding this comment.
Thx. Fixed here and in sendNewPasswordRequest()
| ALTER TABLE {$dbprefix}users_entity | ||
| ADD `password_hash` varchar(255) NOT NULL DEFAULT '' | ||
| AFTER `salt` | ||
| "); |
There was a problem hiding this comment.
Nitpick: the upgrade name implies that running this upgrade makes hashes better, but in fact it only adds a new column.
|
LGTM in general |
This gradually migrates users to modern hashes as they log in; deprecates setting the salt/password attributes in favor of a new setPassword() method (setting salt/password continues to work but will revert the user to the legacy MD5 hashing); and moves core password functionality to a PasswordService object. Fixes Elgg#4665
mrclay
added a commit
that referenced
this pull request
Dec 3, 2014
security(passwords): switches password hashing to password_hash()
|
@juho-jaakkola I addressed your comments and pulled the trigger. |
|
Woohoo this is a big improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(replaces #7495)
This gradually migrates users to modern hashes as they log in; deprecates
setting the salt/password attributes in favor of a new setPassword() method
(setting salt/password continues to work but will revert the user to the
legacy MD5 hashing); and moves core password functionality to a
PasswordService object.
Fixes #4665.