fix(views): deprecated notice no longer shows up in the wrong version #7849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the version was a float it results in version 1.1 and the deprecated notice always shows up.
|
LGTM. The tenses don't match in the commit description, but not a big deal to me. |
|
This PR would deal with #7841 |
juho-jaakkola
pushed a commit
that referenced
this pull request
Feb 3, 2015
fix(views): deprecated notice no longer shows up in the wrong version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the version was a float it results in version 1.1 and the
deprecated notice always shows up.