fix(groups): Hide group profile fields that don't have a value #8040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The group profile displays all profile fields that have a value. | ||
| // We don't want to display fields with empty string value, so we | ||
| // prevent it getting saved by setting the value to null. | ||
| $input[$shortname] = null; |
There was a problem hiding this comment.
Does setting to null actually remove metadata?
There was a problem hiding this comment.
I think we just handle this where we copy $input to metadata. If it's empty string, deleteMetadata() instead.
There was a problem hiding this comment.
ElggEntity in fact first removes the metadata: https://github.com/Elgg/Elgg/blob/1.10/engine/classes/ElggEntity.php#L412
Metadata service later ignores the null value: https://github.com/Elgg/Elgg/blob/1.10/engine/classes/Elgg/Database/MetadataTable.php#L123
There was a problem hiding this comment.
What do you think about using delete or unset() until #8042 is resolved?
added 2 commits
March 9, 2015 09:34
The group profile displays all profile fields that have a value. We don't want to display fields with empty string value, so we now remove the metadata completely.
juho-jaakkola
force-pushed
the
empty_group_profile_strings
branch
from
0b020c6
to
2bb13db
Compare
|
Updated to use |
|
LGTM |
jdalsem
added a commit
that referenced
this pull request
Mar 10, 2015
fix(groups): Hide group profile fields that don't have a value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.