WIP: feature(river): Adds hook-based permissions for river item delete action #8942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclay
force-pushed
the
river_can_delete_8936
branch
from
7950b9e
to
605be9a
Compare
| * @return \ElggUser|false | ||
| * @access private | ||
| */ | ||
| public function resolveUser($guid = 0) { |
There was a problem hiding this comment.
Better suggestions for naming this?
There was a problem hiding this comment.
Can we make this more generic?
I think it would be useful to have something like resolve($guid = 0, $type = null, $subtype = null). We could then use elgg_entity_exists() beforehand, or elgg_instanceof() afterwards.
There was a problem hiding this comment.
Strawman: move the functionality to get(), add $subtype (= null) and $ignore_condition (= false). For this use we'd set $type to "user" and $ignore_condition to true.
There was a problem hiding this comment.
SGTM. I think it will be much cleaner.
mrclay
force-pushed
the
river_can_delete_8936
branch
from
605be9a
to
f9fb4a5
Compare
…ents This also deprecates elgg_delete_river(). Fixes Elgg#8936
mrclay
force-pushed
the
river_can_delete_8936
branch
from
f9fb4a5
to
e799a02
Compare
| @@ -1035,21 +1035,8 @@ public function canEdit($user_guid = 0) { | |||
| * @see elgg_set_ignore_access() | |||
| */ | |||
| public function canDelete($user_guid = 0) { | |||
| $user_guid = (int) $user_guid; | |||
| $user = _elgg_services()->entityTable->resolveUser($user_guid); | |||
There was a problem hiding this comment.
Waiting for #8944 to offer a standard API for this.
|
Replaced by #9964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8936