Merge pull request #103 from Elgg/56-last-action

chore(list): list plugins by last_action - most recent version upload

actions/plugins/create_release.php

@@ -94,6 +94,8 @@
 	'object_guid' => $release->guid,
 ));
 
+update_entity_last_action($plugin_project->guid);
+
 system_message(elgg_echo("plugins:release:saved"));
 
 elgg_clear_sticky_form('community_plugins');

languages/en.php

@@ -36,6 +36,7 @@
 	 *	Object views
 	 */
 	'plugins:uploadtime' => "Uploaded %s (%s)",
+	'plugins:updatedtime' => "Updated %s (%s)",
 	'plugins:release:version_warning' => 'Warning: The author recommends using a different release of this plugin! Do you still want to download this release?',
 	'plugins:download:version' => "Download %s",
 	'plugins:project:title:version' => "%s for Elgg %s",

lib/events.php

@@ -125,4 +125,5 @@ function upgrades() {
 
 	elgg_load_library('plugins:upgrades');
 	run_function_once(__NAMESPACE__ . '\\upgrade_20141121');
+	run_function_once(__NAMESPACE__ . '\\upgrade_20141125');
 }

lib/upgrades.php

@@ -1,6 +1,7 @@
 <?php
 
 namespace Elgg\CommunityPlugins;
+use ElggBatch;
 
 // start using plugin setting version to handle future upgrades
 function upgrade_20141121() {
@@ -12,3 +13,46 @@ function upgrade_20141121() {
 	error_log('setting version');
 	elgg_set_plugin_setting('version', 20141121, PLUGIN_ID);
 }
+
+function upgrade_20141125() {
+
+	$version = (int) elgg_get_plugin_setting('version', PLUGIN_ID);
+	if ($version == 2011111502) {
+		// this didn't happen correctly in the last upgrade
+		// due to some legacy setting
+		elgg_set_plugin_setting('version', 20141121, PLUGIN_ID);
+		$version = 20141121;
+	}
+
+	if ($version >= UPGRADE_VERSION) {
+		return true;
+	}
+
+	$options = array(
+		'type' => 'object',
+		'subtype' => 'plugin_project',
+		'limit' => false
+	);
+
+	$batch = new ElggBatch('elgg_get_entities', $options);
+
+	foreach ($batch as $plugin) {
+		// get most recent release
+		$releases = elgg_get_entities(array(
+			'type' => 'object',
+			'subtype' => 'plugin_release',
+			'container_guid' => $plugin->guid,
+			'limit' => 1,
+			'callback' => false // keep it quick as possible
+		));
+
+		if ($releases[0]->time_created) {
+			update_entity_last_action($plugin->guid, $releases[0]->time_created);
+		}
+		else {
+			update_entity_last_action($plugin->guid, $plugin->time_created);
+		}
+	}
+
+	elgg_set_plugin_setting('version', 20141125, PLUGIN_ID);
+}

pages/plugins/list.php

@@ -36,7 +36,7 @@
 		break;
 	case 'newest':
 	default:
-		$options['order_by'] = 'e.time_created DESC';
+		$options['order_by'] = 'e.last_action DESC';
 		break;
 }
 

start.php

@@ -14,7 +14,7 @@
 define('PLUGINS_CONTRIBUTOR_RELATIONSHIP', 'plugin_contributor');
 
 const PLUGIN_ID = 'community_plugins';
-const UPGRADE_VERSION = 20141121;
+const UPGRADE_VERSION = 20141125;
 
 elgg_register_event_handler('init', 'system', __NAMESPACE__ . '\\init');
 

views/default/object/plugin_project/plugin_project.php

@@ -8,8 +8,8 @@
 	'href' => $project->getURL(), 
 	'text' => $project->title, 
 ));
-$friendlytime = elgg_view_friendly_time($project->time_created);
+$friendlytime = elgg_view_friendly_time($project->last_action);
 $downloads = $project->getDownloadCount();
-$info = "<div class=\"elgg-subtext\">" . elgg_echo('plugins:uploadtime', array($friendlytime, $downloads)) . "</div>";
+$info = "<div class=\"elgg-subtext\">" . elgg_echo('plugins:updatedtime', array($friendlytime, $downloads)) . "</div>";
 
 echo elgg_view_image_block($icon, $link . $info);

views/default/plugins/front/bottom.php

@@ -7,7 +7,12 @@
 
 // Note: Not using elgg_extract because these are potentially expensive database queries.
 if (!isset($vars['newest'])) {
-	$vars['newest'] = elgg_list_entities(array('type' => 'object', 'subtype' => 'plugin_project', 'pagination' => false));
+	$vars['newest'] = elgg_list_entities(array(
+		'type' => 'object',
+		'subtype' => 'plugin_project',
+		'pagination' => false,
+		'order_by' => 'e.last_action DESC'
+		));
 }
 
 if (!isset($vars['popular'])) {

views/default/widgets/plugins/content.php

@@ -20,6 +20,7 @@
 	'subtypes' => array('plugin_project'),
 	'limit' => $number,
 	'offset' => 0,
+	'order_by' => 'e.last_action DESC',
 	'pagination' => false,
 );