Cleanup commands on plugin unload #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jesse-c I think this is definitely a cleaner fix than my previous one! Would you mind removing my additional exclamations on master branch if you haven't already and adding to your changes to make sure my additions don't conflict? Not sure they would or if my changes could have more potential for issues down the road, but if they aren't needed by adding your fix I'd rather remove what I had in there in this PR while submitting your fix. Nice work btw |
|
@mdxprograms my understanding from what tpope and the others were saying is that your changes shouldn't be necessary. I've updated the branch to revert them :) And thanks! But all credit goes to the others pointing out the solution, I just did the implementation |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123. Possible better solution than #144.
Thank you @tpope and others for explaining the issue and fix.
Tested on macOS 10.13.4 with Vim (8.0.1750) and Neovim (0.2.2).