Add filtering of NOASSERTION
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
added a commit
to slint-ui/slint
that referenced
this pull request
Feb 24, 2023
Filter NOASSERTION, as explained in EmbarkStudios/cargo-about#216 (by the example of webpki as well).
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using https://clearlydefined.io to gather license information, that service will conservatively add
NOASSERTIONto the expression for files that contain license like data, but an SPDX license ID could not be confidently ascribed to it. This can result in the license expression for the crate to contain 1 or moreNOASSERTIONidentifiers, which would require the user to accept that (not really valid) ID to pass the license check. By setting this field totrue, files that have aNOASSERTIONid will instead be scanned locally, which will generally either figure out the license, or else skip that file.For a real world example of what this looks like,
webpki:0.22.0's LICENSE file is an ISC license, however it has a preamble that is not part of the ISC license that trips up clearly defined's inspection, causing it to be attributed withISC AND NOASSERTION. Locally scanning the file will be more tolerant and just attribute it withISC.This also makes it so that we actually run cargo about on itself in CI to check that our config is actually good 馃槢