Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wildcard check to bans check #227

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Add wildcard check to bans check #227

merged 2 commits into from
Jul 24, 2020

Conversation

khodzha
Copy link
Contributor

@khodzha khodzha commented Jul 19, 2020

No description provided.

@khodzha khodzha mentioned this pull request Jul 19, 2020
Closed
@repi repi requested a review from Jake-Shadle July 19, 2020 10:16
@Jake-Shadle Jake-Shadle changed the title added wildcards check to check bans Add wildcard check to bans check Jul 22, 2020
@Jake-Shadle
Copy link
Member

I will try and look at this tomorrow, sorry for the wait!

@khodzha
Copy link
Contributor Author

khodzha commented Jul 22, 2020

no problem, take your time! 😃

Jake-Shadle
Jake-Shadle requested changes Jul 23, 2020
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I think just rebasing off main will fix most of the build failures this PR has.

src/bans/mod.rs Show resolved Hide resolved
@khodzha khodzha force-pushed the wildcards branch 2 times, most recently from c7054c3 to 3c40871 Compare July 23, 2020 18:37
@khodzha
Copy link
Contributor Author

khodzha commented Jul 23, 2020

rebased on current main + feedback addressed

Jake-Shadle
Jake-Shadle approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, will update this PR once I make a release with these changes.

@Jake-Shadle Jake-Shadle merged commit 4384053 into EmbarkStudios:main Jul 24, 2020
@khodzha khodzha deleted the wildcards branch July 24, 2020 17:03
@repi repi mentioned this pull request Aug 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khodzha @Jake-Shadle