Support Azure Storage #109
Conversation
src/backends/blob.rs
Outdated
| .put_block_blob() | ||
| .with_container_name(&self.container) | ||
| .with_blob_name(&self.make_key(krate)) | ||
| .with_content_type("text/plain") |
There was a problem hiding this comment.
These are compressed tarballs, not text, was there a reason for setting this content type?
There was a problem hiding this comment.
Sorry, it is just as a placeholder. Should it be application/x-tar?
There was a problem hiding this comment.
Ok. Let me add a commit. Thanks for your patient.
src/backends/blob.rs
Outdated
| Ok(list | ||
| .incomplete_vector | ||
| .iter() | ||
| .map(|o| o.name.clone()) |
There was a problem hiding this comment.
I don't know how list works for azure, but the other backends filter the results only to the items that match the prefix specified for the backend. Also, you should be able to do into_iter here to avoid doing a clone of the string.
There was a problem hiding this comment.
Got it. this just followed the advice of cargo clippy. It will be fixed in the next commit.
Btw, this demand of Azure has existed for a long time. I guess this is not an important task. Do you have a list of important tasks? I can make a contribution and learn how to write Rust.
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Sorry. I just realized that I need to commit the |
Relate to #4