Add support for EXC_GUARD #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mach defines several things like exception_type and code and subcode as signed types, when in practice they are always unsigned
The exception message was not `packed(4)` which ended making us lose information, oops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
EXC_GUARDmask so that those exceptions can now be caught incrash-handler. This includes adding support for rasingEXC_GUARDexceptions from sadness generator.While testing the minidumps generated from an
EXC_GUARDI found out that crash-handler was accidentally truncating the code and subcode of the exceptions since I had forgottenpacked(4)on the structure that receives the exception details from the mach exception port, basically causing all of the minidumps created from a crash-context captured by the crash-handler to be missing information. Fixing that by looking at the code generated formig mach_exc.defsmade me also realize why the mach IPC stuff in crash-context was "weird". When receiving messages, one needs to always account for the "trailer" placed at the end by the kernel, so now that code is cleaner as well.Also improved documentation by linking directly to the xnu sources in github.
Resolves: #34