Add pthread_create interpose #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went down a rabbit hole due to https://github.com/criblio/appscope/blob/15fdf115874731d86f84105b128f86f4afa0f67d/src/fn.c#L14-L84 but never got it working, but looking at the musl source, the implementation is in |
This intercepts pthread_create to ensure an alternate signal stack is always installed to ensure that stack overflows can always be caught no matter if the thread is created via Rust's std::Thread or otherwise
Jake-Shadle
force-pushed
the
ptrace-intercept
branch
from
214f1d4
to
ab60a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the code from https://hg.mozilla.org/mozilla-central/file/3cf2b111807aec49c54bc958771177d33925aace/toolkit/crashreporter/pthread_create_interposer/pthread_create_interposer.cpp so that
pthread_createalways installs an alternate signal stack, regardless of whether the thread is created in Rust or from C/C++ (barring shenanigans).This works in glibc, but not musl, so will have to tackle that another time.
Resolves: #4