Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Update egui dependency to v0.25 #179

Merged
merged 8 commits into from
Jan 12, 2024
Merged

⬆️ Update egui dependency to v0.25 #179

merged 8 commits into from
Jan 12, 2024

Conversation

tosti007
Copy link
Contributor

@tosti007 tosti007 commented Jan 9, 2024 •
edited by emilk
Loading

Description of Changes

This PR updates the egui dependency to the latest version 0.25. I believe I have updated all required lines (being only one). This PR does add some duplicated dependencies down the line unfortunately.

TimonPost
TimonPost reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@TimonPost TimonPost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Lots of dependency changes, maybe expected, but can you check if there are feature flags that are added and can be disabled, or see what dependencies cause duplication of dependencies. Ideally we minimize this.

Cargo.lock Outdated Show resolved Hide resolved
Cargo.lock Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
@fornwall
Copy link
Contributor

fornwall commented Jan 10, 2024 •
edited
Loading

cargo update -p is-terminal should fix the duplicated rustix and linux-raw-sys dependencies.

@tosti007
Copy link
Contributor Author

Alright, I just force pushed the branch with some reworked commits. I updated the indexmap dependency to v2.1.0, since that resolved a duplicate dependency. Other than that it's mostly the new winit v0.29.4 requirement of egui v0.25.0 which introduces quite a few new dependencies. Regarding duplicate dependencies I managed to remove quite a few of them, with the exception of libloading (mainly winit -> x11rb -> old version), bitflags (many crates haven't updated yet), redox_syscall (orbclient not updated).

TimonPost
TimonPost approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now! winit upgrade introduced quite some new dependencies but not sure if we can disable more feature flags. Anyhow this is good now!

@emilk emilk merged commit b0c11ae into EmbarkStudios:main Jan 12, 2024
5 of 6 checks passed
@tosti007 tosti007 deleted the egui_v0.25 branch January 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

@TimonPost TimonPost TimonPost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update puffin_egui to 0.25.0
4 participants
@tosti007 @fornwall @emilk @TimonPost