Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended version of puffin::profile_scope!() #213

Merged

Conversation

v0x0g
Copy link
Contributor

@v0x0g v0x0g commented May 19, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Add extended version of puffin::profile_scope!() that expands to an expression instead of variable

  • This allows for profiling scopes to persist for custom scopes, instead of being limited to block scopes
  • Includes doctests and real-world example

Related Issues

As per request from @chrisduerr in #194

… expression instead of variable

- This allows for profiling scopes to persist for custom scopes, instead of being limited to block scopes
- Includes doctests and real-world example
puffin/src/lib.rs Outdated Show resolved Hide resolved
@v0x0g
Copy link
Contributor Author

v0x0g commented Jun 25, 2024

@emilk @TimonPost Any update on this?

v0x0g added a commit to v0x0g/fork-puffin that referenced this pull request Jun 25, 2024
…ure/puffin_http_server_custom_profiler'

Merge custom features branches, for use in rayna

- EmbarkStudios devs haven't merged PR EmbarkStudios#212 EmbarkStudios#213 yet
Copy link
Collaborator

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - thanks!

@emilk emilk merged commit 232bf81 into EmbarkStudios:main Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants