🪂 Disable drag_to_scroll on frame selection ScrollArea

[tosti007]

Redo of #207

Checklist

• I have read the Contributor Guide
• I have read and agree to the Code of Conduct
• I have added a description of my changes and why I'd like them included in the section below

Description of Changes

In the version 0.27 release of egui, the interaction handling was changed. This caused the scope selection in the flamegraph to be unselectable. By disabling the drag_to_scroll on the related ScrollArea this issue is solved.

The latest scope selection does not suffer from this, as it does not use a ScrollArea.

Note that this does not have any behavioral effect, but instead results in the same behavior of click/drag/scroll when on egui 0.26!

Related Issues

• Fixes 🍳 puffin-egui: Incorrect flamegraph frame selection input handling  #205

Tested on

Edit tasklist title

Beta Give feedback Tasklist Tested on, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Windows

   Windows
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Linux

   Linux
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Mac

   Mac
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Android

   Android
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Tested on Loading

[MarijnS95]

You can check "Tested on Linux" (via cargo r -p puffin_egui --example eframe). You're right that dragging only scrolls as soon as a scrollbar is necessary, never allowing to select frames anymore.

[Hoodad]

FYI I have found the source of the issue but I'm not well versed with egui yet to understand how to fix the issue, see #219. Not sure if we want this in if we can get the root issue resolved?

[MarijnS95]

@Hoodad the root cause is already highlighted in this PR description, I think. The solution is given here as well, all that is required is for this PR to be merged 😉

[Hoodad]

Hmm fair enough I didn't consider disabling the drag_to_scroll to solve the problem, but maybe it should be considered to solve it? Have you tested the change on Android as that's where I would expect this change to degrade the experience the most as there wouldn't be any way of scrolling through the frames if I understood the change correctly?

[Hoodad]

Okay I just now tested the change on Android as well and it works (the UI is a bit too cramped to use on a small screen) like on desktop you have to scroll by grabbing the scrollbar which I consider good enough.

I wanted to get to the bottom with this and investigate an alternative solution that I got working that changes the logic inside show_frame_list to work without having to set drag_to_scroll to false. But after some testing I cannot see any drawback with this PR and its less code change then compared to my alternative method. So thumbs up from me👍

[rib]

and testing on Windows this fix seems to work nicely here

[Hoodad]

@tosti007 can you or @MarijnS95 fix the merge conflict so we can have the change merged?