Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linker/test: prepare for SPIR-T compatibility. #961

Merged
merged 5 commits into from Dec 9, 2022

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Dec 5, 2022

This is a prerequisite for:

Each commit is an individual step and can be reviewed as such, but the notable ones are:

  • removed "decoration groups" (we don't generate them, they're deprecated, SPIR-T does not support them)
  • added a mechanism to keep Exports around long enough so SPIR-T can understand what these tests want
  • flipped on DCE (which will remove otherwise-unused definitions) and added more Exports to keep things alive

Overall I really have not liked these tests and they're the main reason the SPIR-T PR got delayed so much.
I opened an issue about moving away from these unit tests, but sadly I don't know how much effort it'd be:

@eddyb eddyb merged commit 32db2b4 into EmbarkStudios:main Dec 9, 2022
@eddyb eddyb deleted the linker-test-spirt-prep branch December 9, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants