linker/test: prepare for SPIR-T compatibility. #961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for:
RUSTGPU_CODEGEN_ARGS=--spirt
). #940 (comment)(the link goes to my comment explanation the plan that this PR is a part of)
Each commit is an individual step and can be reviewed as such, but the notable ones are:
Export
s around long enough so SPIR-T can understand what these tests wantExport
s to keep things aliveOverall I really have not liked these tests and they're the main reason the SPIR-T PR got delayed so much.
I opened an issue about moving away from these unit tests, but sadly I don't know how much effort it'd be:
rustc_codegen_spirv::linker::test
unit tests with compiletest ones. #957