Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpAtomicFMaxEXT being used inside atomic_f_add #995

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Fix OpAtomicFMaxEXT being used inside atomic_f_add #995

merged 3 commits into from
Mar 22, 2023

Conversation

BeastLe9enD
Copy link
Contributor

Fixes #994

eddyb
eddyb suggested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for forgetting about this! Can you add a CHANGELOG entry?
(please ping me for reviews)

@BeastLe9enD
Copy link
Contributor Author

@eddyb I added the changelog entry, now this should be ready :)

@eddyb eddyb merged commit b67ad40 into EmbarkStudios:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

@oisyn oisyn Awaiting requested review from oisyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect spirv instruction OpAtomicFMaxEXT used in atomic_f_add
2 participants
@BeastLe9enD @eddyb