Remove '$' character from generated symbol name in '_$union' suffix #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating the symbol names, don't use the '$' character in the suffix string; this is not a valid Python identifier. The symbol name is used when generating the Python class name; this name is not used when generating the C code.
|
Hello @RamseyTI , thank you for this PR, please give me some time to review and evaluate. Thank you. |
MichalPrincNXP
approved these changes
Aug 3, 2020
|
Thank you, @RamseyTI , for providing this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the symbol names, don't use the '$' character in the
suffix string; this is not a valid Python identifier. The symbol name
is used when generating the Python class name; this name is not used
when generating the C code.