-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message loggin fix #127
Merged
MichalPrincNXP
merged 3 commits into
EmbeddedRPC:develop
from
Hadatko:message_loggin_fix
Sep 18, 2020
Merged
Message loggin fix #127
MichalPrincNXP
merged 3 commits into
EmbeddedRPC:develop
from
Hadatko:message_loggin_fix
Sep 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdbool.h is included twice in erpc_server_setup.h now, it should be removed from extern "C" section, I guess
Well these are headers for C i would keep it there, i just didn't notice. I will update all three headers. Thank you . |
It should be correct now. |
MichalPrincNXP
approved these changes
Sep 18, 2020
Thank you, Dusan! |
Hadatko
added a commit
to Hadatko/erpc
that referenced
this pull request
Sep 23, 2020
Message loggin fix EmbeddedRPC#127
Hadatko
added a commit
to Hadatko/erpc
that referenced
this pull request
Sep 23, 2020
Message loggin fix EmbeddedRPC#127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is solving warnings with MessageLoggers constructor isiden client/server object and also solving error with missing bool type in setup functions when Logger is enabled.