Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message loggin fix #127

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Sep 17, 2020

This is solving warnings with MessageLoggers constructor isiden client/server object and also solving error with missing bool type in setup functions when Logger is enabled.

@Hadatko Hadatko added the bug label Sep 17, 2020
@Hadatko Hadatko self-assigned this Sep 17, 2020
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdbool.h is included twice in erpc_server_setup.h now, it should be removed from extern "C" section, I guess

@Hadatko
Copy link
Member Author

Hadatko commented Sep 18, 2020

Well these are headers for C i would keep it there, i just didn't notice. I will update all three headers. Thank you .

@Hadatko
Copy link
Member Author

Hadatko commented Sep 18, 2020

It should be correct now.

@MichalPrincNXP MichalPrincNXP merged commit 96132ca into EmbeddedRPC:develop Sep 18, 2020
@MichalPrincNXP
Copy link
Member

Thank you, Dusan!

Hadatko added a commit that referenced this pull request Sep 23, 2020
Hadatko added a commit to Hadatko/erpc that referenced this pull request Sep 23, 2020
Hadatko added a commit to Hadatko/erpc that referenced this pull request Sep 23, 2020
@Hadatko Hadatko deleted the message_loggin_fix branch September 25, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants