Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/static allocation #169

Merged

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Mar 15, 2021

More static memory usage possibility (still shim code not fully supporting and not all transports are using new macros).
PR which should be merged after these: #153 #168

@Hadatko Hadatko self-assigned this Mar 15, 2021
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@MichalPrincNXP
Copy link
Member

Thank you, Dusan, quite massive changes to be reviewed and tested, let's target these changes for the next release (after v1.8.1 release), ok? Thanks.

@Hadatko
Copy link
Member Author

Hadatko commented Jun 24, 2021

Hi @MichalPrincNXP , yes sure ;)

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@MichalPrincNXP
Copy link
Member

After merging this PR with #168 and using rpmsg_lite with updated static allocations, I got my erpc_matrix_multiply_rpmsg_rtos example running. @Hadatko what way of integrating all into the mainline do you prefer? Thank you.

@Hadatko
Copy link
Member Author

Hadatko commented Sep 14, 2021

@MichalPrincNXP That is great. Sorry i don't know what you are asking for. Normal procedure is fine for us (review and merge into develop branch)

@Hadatko
Copy link
Member Author

Hadatko commented Sep 14, 2021

I see conflicts, i can resolve them. Not sure if Manually constructed changes PR was merged.

@Hadatko
Copy link
Member Author

Hadatko commented Sep 14, 2021

Conflicts should be solved.

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is linked with #168 and will be integrated together. Nevertheless, this does not allow static allocation of all erpc objects and the work on the static allocations needs to continue (information for others looking at this PR). "Known issues and limitations" section should be added into the wiki with following statement:
Static allocations controlled by the ERPC_ALLOCATION_POLICY config macro are not fully supported yet, i.e. not all erpc objects can be allocated statically now. It deals with the ongoing process and the full static allocations support will be added in the future.

@MichalPrincNXP MichalPrincNXP merged commit dab9fd1 into EmbeddedRPC:develop Sep 22, 2021
@MichalPrincNXP
Copy link
Member

Thank you for the effort!

@Hadatko Hadatko deleted the feature/staticAllocation branch February 4, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants