Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage of rpmsg static freertos related api #168

Merged
merged 9 commits into from
Sep 22, 2021
Merged

Allow usage of rpmsg static freertos related api #168

merged 9 commits into from
Sep 22, 2021

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Mar 10, 2021

This change depends on nxp-mcuxpresso/rpmsg-lite#14

@Hadatko Hadatko self-assigned this Mar 10, 2021
@Hadatko Hadatko mentioned this pull request Mar 15, 2021
Merged
@Hadatko
Added check for rpmsg if it is using static api when erpc is set to u…
20692a1 
…se static api

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko
Fixed static macro usage
ae96b68 
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@MichalPrincNXP
Copy link
Member

Hi Dusan, let's target these changes for the next release (after v1.8.1 release), ok? Thanks.

@Hadatko
Copy link
Member Author

Hadatko commented Jun 24, 2021

Hi @MichalPrincNXP , yes sure ;)

@MichalPrincNXP
Copy link
Member

#if ERPC_ALLOCATION_POLICY == ERPC_STATIC_POLICY
macro names need to be aligned with #169

@Hadatko
Copy link
Member Author

Hadatko commented Sep 14, 2021

Sure, will do

@Hadatko
Copy link
Member Author

Hadatko commented Sep 14, 2021

Fixes pushed. Is that ok now?

@Hadatko
Update rpmsg dependency based on lates rpmsg changes.
68b32b2 
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko
Copy link
Member Author

Hadatko commented Sep 20, 2021

Update pushed.

MichalPrincNXP
MichalPrincNXP approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is linked with #169 and will be integrated together. Nevertheless, this does not allow static allocation of all erpc objects and the work on the static allocations needs to continue (information for others looking at this PR). "Known issues and limitations" section should be added into the wiki with following statement:
Static allocations controlled by the ERPC_ALLOCATION_POLICY config macro are not fully supported yet, i.e. not all erpc objects can be allocated statically now. It deals with the ongoing process and the full static allocations support will be added in the future.

@MichalPrincNXP MichalPrincNXP merged commit 810916e into EmbeddedRPC:develop Sep 22, 2021
@MichalPrincNXP
Copy link
Member

Thank you for this effort!

@Hadatko Hadatko deleted the feature/staticRPMSGApi branch February 4, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalPrincNXP MichalPrincNXP MichalPrincNXP approved these changes

Assignees

@Hadatko Hadatko

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hadatko @MichalPrincNXP