Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid for serial and enum34 dependency. #247

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Feb 24, 2022

enum34 is in python3 since 3.4 (from 2014)
why to install serial module when i want to use other transport

Signed-off-by: Cervenka Dusan cervenka@acrios.com

enum34 is in python3 since 3.4 (from 2014)

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko self-assigned this Feb 24, 2022
@Hadatko
Copy link
Member Author

Hadatko commented Feb 24, 2022

This is not tested. What do you think about proposed changes? @MichalPrincNXP

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko
Copy link
Member Author

Hadatko commented Mar 10, 2022

Hi @MichalPrincNXP i fixed python dependency in documentation. Ready for merge.

@MichalPrincNXP MichalPrincNXP merged commit 944baa7 into EmbeddedRPC:develop Mar 10, 2022
@MichalPrincNXP
Copy link
Member

Thanks for the update.

@Hadatko Hadatko deleted the feature/get_rid_of_serial_dependency branch March 21, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants