-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't check for null pointer before free, it should be handled in the free function #275
Conversation
this commit fixes #274 |
Hi @amgross , thank you for PR, looks great. I will check other port layers if they don't need check for NULL and let you know. |
I took a look on the ports and all looked OK for me, but second glance is always good |
Hi @amgross:
|
Mine PR related to this: #277 |
Hi @Hadatko , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this PR.
What is the flow of merging in this repository? |
@amgross i am letting merging on @MichalPrincNXP. He is performing also more tests directly on NXP devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry for the delay, thank you for this PR.
Pull request
Choose Correct
Describe the pull request
Stop checking if pointer is NULL before sending it to the erpc_free function. The erpc_free should handle NULL pointer properly (like c standard free)
To Reproduce
Generate code that allocating space on the heap.
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context