Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spidev init #363

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Fix spidev init #363

merged 2 commits into from
Jun 2, 2023

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented May 24, 2023

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

Fixing spidev init. Initializing status flag.

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

@Hadatko
Fix spidev init
27aad72 
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko added the bug label May 24, 2023
@Hadatko Hadatko added this to the 1.11.0 milestone May 24, 2023
@Hadatko Hadatko self-assigned this May 24, 2023
@Hadatko Hadatko linked an issue May 24, 2023 that may be closed by this pull request
Uninitialized local variable leads to no SPIDEV init #362
Closed
@Hadatko
Fix receive error value for spidev
a05548e 
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko linked an issue May 24, 2023 that may be closed by this pull request
Returning wrong error code for SpidevMaster receive #364
Closed
@Hadatko Hadatko modified the milestones: 1.11.0, 1.12.0 Jun 1, 2023
@MichalPrincNXP MichalPrincNXP merged commit 781fb03 into EmbeddedRPC:develop Jun 2, 2023
1 check passed
@MichalPrincNXP
Copy link
Member

Thank you for the bugfix

@Hadatko Hadatko deleted the bugfix/spidev_init branch June 2, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalPrincNXP MichalPrincNXP MichalPrincNXP approved these changes

Assignees

@Hadatko Hadatko

Labels
bug
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Returning wrong error code for SpidevMaster receive Uninitialized local variable leads to no SPIDEV init
2 participants
@Hadatko @MichalPrincNXP