This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Remove deprecation warning #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `set` inside a `didInsertElement` hook throws deprecation warnings in development environments. This instead sets the properties during the next run loop.
|
Setting properties on next tick is causing tests to fail. I'll try and figure out what's up. |
This was referenced Jul 8, 2016
|
👍 |
|
Thanks for the PR and sorry for the long delay! |
tszymon
pushed a commit
to tszymon/ember-cli-swiper
that referenced
this pull request
Aug 11, 2023
…_yarn/engine.io-6.4.2 Bump engine.io from 6.1.3 to 6.4.2
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
setinside adidInsertElementhook throws deprecation warnings in development environments. This instead sets the properties during the next run loop.