fix: fix transfer recipient address #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitjuh
requested review from
clockworkgr,
luciorubeens,
pranaybaldev,
Raymahni,
caudurodev,
fl-y,
mihailmarcu and
Dawntraoz
as code owners
|
Failed build 😭 @helder-moreira |
Deploying with
|
| Latest commit: |
7854b7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d1d3e81.emeris-app.pages.dev |
fl-y
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the issue described by Nass here: https://allinbits.slack.com/archives/C02AXJ0K9F1/p1650576878932699
We were only showing the recipient address for "move", but not for "transfer".
I'm not entirely sure why this check on
detail.to.chainwas there. It is undefined for transfers, probably because it doesn't move chain, so I didn't see any harm in removing the check. Please double check if that doesn't break anything.Transfers + Moves should be tested