Fix download failure for games with missing hash data #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API doesn't return `md5_hash` for some game files. This would cause the error `KeyError: 'md5_hash'` to be thrown and skip the rest of the downloads for that game. This changes the behavior so that it just skips verification of files without a MD5 hash.
The linter was complaining about `Game.do_download()` being too big (too many variables/returns/branches/statements), so I created `Game.backup_download()` to handle the code that verified and backed up existing files.
TheFrenchGhosty
added a commit
to TheFrenchGhosty/itchio-fixed
that referenced
this pull request
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that not all files will have a
md5_hash. When this program tries to download those file, the errorKeyError: 'md5_hash'is thrown and the rest of the downloads for that game are skipped.This PR changes the behavior of this program so that it just skips verification of files without a MD5 hash.
Here is a collection of games that I know to be affected: