Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download failure for games with missing hash data #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix download failure for games with missing hash data #80

wants to merge 2 commits into from

Commits on Apr 15, 2023

  1. Fix download failure for games with missing hash data 

    The API doesn't return `md5_hash` for some game files. This would cause the
error `KeyError: 'md5_hash'` to be thrown and skip the rest of the
downloads for that game.

This changes the behavior so that it just skips verification of files
without a MD5 hash.
    @triple-j
    triple-j committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    ceefc90 View commit details
    Browse the repository at this point in the history

  2. Break up Game.do_download() into multiple methods 

    The linter was complaining about `Game.do_download()` being too big (too
many variables/returns/branches/statements), so I created
`Game.backup_download()` to handle the code that verified and backed up
existing files.
    @triple-j
    triple-j committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    c8b8e0a View commit details
    Browse the repository at this point in the history