New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPCS 3.1, PHPStan and workflows #123

Open

jdevalk wants to merge 6 commits into develop from jdv/wpcs31

Member

jdevalk commented Apr 5, 2024 •

edited

Loading

Context

Added PHPStan
Updated WPCS to 3.1
Fixed errors
Updated tested up to WP version
Update WP version matrix

Quality assurance

I have tested this code to the best of my abilities.
I have added unit tests to verify the code works as intended.
I have checked that the base branch is correctly set.

Fixes #

jdevalk added 2 commits

April 5, 2024 22:25


          Update to WPCS 3.1 and add phpstan + add workflows

81c2970


          Add phpstan workflow

23904e4

github-actions bot commented Apr 5, 2024 •

edited

Loading

WordPress Playground

You can easily test this pull request on the WordPress Playground, or download the zip file.

jdevalk added 4 commits

April 5, 2024 22:28


          Fix CS

dde6558


          Fix composer.lock

40ddff6


          Fix phpstan

fc425fe


          Fix WP matrix

f9996cb

jdevalk requested a review from aristath

April 5, 2024 20:34

aristath approved these changes

View reviewed changes

Member

aristath left a comment

Didn't test it, but the code looks good.
I can test it on Monday, but looks ok to merge 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet