Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscilloscope: Add isStartingConnection timeout to avoid hangs when selected EmotiBit disappears #118

Closed
produceconsumerobot opened this issue May 6, 2022 · 0 comments · Fixed by #121

Comments

@produceconsumerobot
Copy link
Collaborator

produceconsumerobot commented May 6, 2022

Probably ~3-5 seconds would be good inside of https://github.com/EmotiBit/ofxEmotiBit/blob/master/src/EmotiBitWiFiHost.cpp#L233

isStartingConnection = false;
connectedEmotibitIp = "";

Testing

  • Open Oscilloscope with EmotiBit in device list but not connected
  • Press and hold EmotiBit reset button
  • Quickly click to connect to EmotiBit in Oscilloscope before it grays out
  • Oscilloscope will be frozen for 5 seconds
  • After 5 seconds, the connection should time out and oscilloscope should unfreeze
@produceconsumerobot produceconsumerobot changed the title Add isStartingConnection timeout to avoid hangs when selected EmotiBit disappears Oscilloscope: Add isStartingConnection timeout to avoid hangs when selected EmotiBit disappears May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant