Feat advertising options

[produceconsumerobot]

Description

Added a number of features and fixes to enable greater flexibility with advertising.

Requires

• https://github.com/jeffcrouse/ofxJSON

New Features

• closes Oscilloscope: Add json support to set Advertising scheme #108
• closes Oscilloscope: Add an advertising network includeList and exludeList in emotibit comms json file #117

Fixes

• fixes Oscilloscope: Add if(enableBroadcast) to all advertising areas #116
• fixes Oscilloscope: Add isStartingConnection timeout to avoid hangs when selected EmotiBit disappears #118

[nitin710]

Testing

Broadcasting vs Unicasting difference

• Testing Notes

  • Case 1:

    • 3 Oscilloscopes(v1.4.4-feat-advertisingOptions.6) open in Windows-dev(running app-debug.exe) with broadcast enabled
    • 1 oscilloscope(v1.4.4) open in deploy

  • Case 1 observations using unicast

    • The 3 oscilloscopes in dev are connected continuously and streaming without problem
    • When the oscilloscope(v1.4.4) was started on deploy, it did not show up any emotibits on the network(for some time). Then all EmotiBits shoed up as expected.
    • Momentarily, all 3 v1.4.4-feat-advertisingOptions.6 oscilloscopes dropped their connections to EmotiBits. I wonder is v1.4.4 coming on the network had an effect?
    • V1.4.4 dropped connection to emotibit after 2 minutes. But v1.4.4-feat-advertisingOptions.6 is continuously connected and streaming well

  • Case 2:

    • 3 - 3 Oscilloscopes(v1.4.4-feat-advertisingOptions.6) open in Windows-dev(running app-debug.exe) with unicast enabled
    • 1 oscilloscope(v1.4.4) open in deploy

  • Case 2 observations

    • v1.4.4-feat-advertisingOptions.6
    • There is a lag in picking up emotibits on the network
    • more frequent dropping
    • more perceived lag in streaming
    • lag while connecting to EmotiBits
    • v1.4.4
      • has not dropped an EmotiBit since the beginning
      • Looks to be streaming OK

  • Case 3:

    • v1.4.4-feat-advertisingOptions.6
      • Started 2 oscilloscopes in unicast mode
      • changed transmission -> broadcast in JSON file
      • Started another instance of oscillosocpe

  • Case 3 observations:

    • After ~10 mins, only the oscilloscope using broadcast was connected and streaming data from Emotibits. The other EmotiBits seemed to have disconnected from their emotibits

Transmission	Network Name	Router model #	# EmotiBits on network	# Oscilloscopes on network	Observation duration	# drops	# disconnects
broadcast	EmotiNet	AC750	6	3x 1.4.4-feat-advertisingOptions.6 1x v1.4.4	30 mins	1-2(on 1.4.4-feat-advertisingOptions.6) multiple - v1.4.4	1 - 1.4.4-feat-advertisingOptions.6 multiple -v1.4.4
unicast	EmotiNet	AC750	6	3x 1.4.4-feat-advertisingOptions.6 1x v1.4.4	10 mins	few(on 1.4.4-feat-advertisingOptions.6) none - v1.4.4	multiple - 1.4.4-feat-advertisingOptions.6 multiple -v1.4.4

Unicast range

EmotiBits are allocated IPs starting from 100.

Test Case	Output
Toggling both broadcast and unicast OFF	✔️ All EmotiBits are found If both broadcastunicast is used by default, (according to the code as is)
Unicast range does not include EmotiBit IPs	✔️ No emotibits found
Unicast range extended to cover only 1 Emotibit	✔️ Only 1 EmotiBit found
Unicast range extended to cover only 2 EmotiBits	✔️ 2 EmotiBits found

Whitelist vs blacklist

Available networks(adapters) on the computer:

All Network(s): [192.168.40.*] [192.168.193.*] [192.168.1.*]
Emotibits on network: 192.168.1.*

Case	output
Include list is not empty and does not contain EmotiBit network	✔️ EmotiBits not detected
Include list = emotibit network	✔️ All EmotiBits found
Include list contains > 1 networks, and EmotiBit network is a part of the list	✔️ All EmotiBits on network found
EmotiBit network added to the exclude list	✔️ EmotiBits not found on network

[nitin710]

Tests still needed to be performed

• Test broadcast/unicast on iphone hotspot
• Test for Oscilloscope: Add isStartingConnection timeout to avoid hangs when selected EmotiBit disappears #118

[nitin710]

Tests

• ✔️ Oscillosocpe on iPhone hotspot

transmission type	result
broadcast	not detected
unicast	detected

• ✔️ Oscilloscope: Add isStartingConnection timeout to avoid hangs when selected EmotiBit disappears #118

[nitin710]

Approved for merge