New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Retroarch setkillkey option #1109
Dev Retroarch setkillkey option #1109
Conversation
added defaults should fix res switching problem.
ws fix
preset display/mode with dummy initial values so when the correct value is updated, this ensures the mode refreshes properly.
removed changing of mode for cvbs
test fixes 576cvbs, 1280x1024 too.
rm mode set checks.
config option to enable new joy sort ordering.
updated setres.sh.
Removed fbset to fb1 as corrupting screen, and making ES font disappear.
initial commit.
ws fix
can commit. This will only take effect if the user creates the file flag. |
The only issue I have with this is that when killing Retroarch like this, any settings they change manually will revert even the ones not set by ES. Maybe a better solution would be to add it in ES under the danger zone menu? with an explanation on what the downside is? I guess the way you set it up right now is obscure enough that if people so this they already know there are downsides. |
It's more for debugging when RA sometimes crashes in emulators, and those that are adamant that they need the function. Ordinarily for most users, I would not recommend that its needed. Putting it in the danger menu adds code, and people might be more likely to enable it out of curiosity lol. |
I have had a few people come to me with issues about exiting the Retroarch emulator and it's usually to do with the hotkey button and multiple controllers not being able to work with the hotkey code.
So I created an option to have a file "/storage/.config/RA_KILL_KEYS" which will add retroarch and retrorun to the set_kill_keys. Ordinarily most do not need this config, but it would save allot of time if this can be enabled for those who have issues.