Backend logging #535
Merged
Backend logging #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigamasta
reviewed
May 16, 2019
| @@ -61,6 +62,20 @@ async function _new(req, res) { | |||
| ApolloServer.prototype.createGraphQLServerOptions = _new | |||
| // end of workaround | |||
|
|
|||
| const getLogger = (uuid) => { | |||
| const logToJSON = (v) => console.log(JSON.stringify(v, null, 2)) // eslint-disable-line | |||
There was a problem hiding this comment.
console.log? I was hoping we get something better, like winston. Although I haven't investigated further, I saw this discussion apollographql/apollo-server#1264 @ppershing?
There was a problem hiding this comment.
I can add it in subsequent PR?
| @@ -69,6 +84,7 @@ const server = new ApolloServer({ | |||
| }, | |||
| // TODO: replace with production-ready logger | |||
| formatError: (error: GraphQLError): any => { | |||
| // TODO: how can we get Context here, so that we can connect error to request uuid? | |||
There was a problem hiding this comment.
I think second parameter to this function is context
There was a problem hiding this comment.
No it is not, not according to docs, and when I tried I got undefined here.
There was a problem hiding this comment.
Oh, Okay, then it's probably second parameter to formatResponse I guess
ppershing
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.