Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shin/ch2324/add-notification-page #1195

Merged
merged 24 commits into from Dec 23, 2019
Merged

shin/ch2324/add-notification-page #1195

merged 24 commits into from Dec 23, 2019

Conversation

shinsuny
Copy link
Contributor

@shinsuny shinsuny commented Dec 10, 2019 •
edited

This PR adds notification page, I call it notice board page because we already have a banner style notification system.

See spec.

TODOS

Item Priority Status
Fix Today's time format HIGH ✔️
Add load more button HIGH ✔️
No notice page HIGH ✔️
Fix other UI issues HIGH ✔️
Add all certificate text HIGH ✔️
Update spec HIGH ✔️
Change API request to Cached Request HIGH TODO
Fix API part of fetching data HIGH TODO
Add E2E cases HIGH TODO
Add JEST cases HIGH TODO

For custom duration formatting:

@shinsuny shinsuny self-assigned this Dec 10, 2019
@shinsuny shinsuny marked this pull request as ready for review December 17, 2019 13:19
@SebastienGllmt SebastienGllmt merged commit a82e330 into shelley Dec 23, 2019
@SebastienGllmt SebastienGllmt deleted the shin/ch2324/add-notification-page branch December 23, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastienGllmt SebastienGllmt SebastienGllmt approved these changes

@nicarq nicarq Awaiting requested review from nicarq

Assignees

@shinsuny shinsuny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shinsuny @SebastienGllmt