Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/footer help links #199

Merged
merged 2 commits into from Dec 29, 2018
Merged

Feature/footer help links #199

merged 2 commits into from Dec 29, 2018

Conversation

shinsuny
Copy link
Contributor

No description provided.

@shinsuny shinsuny added WIP / DO NOT MERGE Shows that a PR shouldn't be merge small-scale change Changes that are not NFC but small enough in scope that they don't need to go through triage labels Dec 28, 2018
shinsuny pushed a commit that referenced this pull request Dec 28, 2018
footer help links (#199)
c6cc41a
shinsuny pushed a commit that referenced this pull request Dec 28, 2018
footer help links (#199)
f310def
@shinsuny shinsuny removed the WIP / DO NOT MERGE Shows that a PR shouldn't be merge label Dec 28, 2018
This was referenced Dec 28, 2018
Closed
Closed
@shinsuny shinsuny added the WIP / DO NOT MERGE Shows that a PR shouldn't be merge label Dec 28, 2018
shinsuny pushed a commit that referenced this pull request Dec 28, 2018
footer help links (#199)
0aaf21f
shinsuny pushed a commit that referenced this pull request Dec 28, 2018
footer help links (#199)
c3ea344
@shinsuny shinsuny removed the WIP / DO NOT MERGE Shows that a PR shouldn't be merge label Dec 28, 2018
@nicarq
Copy link
Contributor

nicarq commented Dec 29, 2018 •
edited

good job, Shin! LGTM :D

@nicarq nicarq merged commit 683c482 into develop Dec 29, 2018
@nicarq nicarq deleted the feature/footer-help-links branch December 29, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicarq nicarq nicarq approved these changes

@SebastienGllmt SebastienGllmt Awaiting requested review from SebastienGllmt

@vsubhuman vsubhuman Awaiting requested review from vsubhuman

@JizKadasha JizKadasha Awaiting requested review from JizKadasha

Assignees
No one assigned
Labels
small-scale change Changes that are not NFC but small enough in scope that they don't need to go through triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shinsuny @nicarq