-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly / 4.5.5001 #2179
Nightly / 4.5.5001 #2179
Conversation
P2S outputs supported P2S inputs do not seem to work - more testing is needed. Yoroi signs them without returning any errors, but when submitted to the network they are not accepted.
We must use the inputs given to us as boxes to sign as even if we arent directly signing them (P2S inputs) they need to be included in the tx signing in sigma-rust. P2S inputs weren't found in the user's UTXOs so they were silently filtered from the signing process unintentionally. We will still need to update this later to get the keys in the same way somehow or find a different way for the cases where it's a UTXO we'd have control to sign over but it hasn't yet been put in our DB (e.g. pending txs which was the reason why we changed UnsignedInputs to include the full data in the first place)
Check delegation status and display a warning if the wallet hasn't delegated
Trezor wallet Catalyst voting registration support
…ime one week further
Catalyst Fund4 another date push
Remove repeated function
Changed nightly build action to use `nightly` branch
Release/4.5.0
[quickfix] Release/4.5.1 Catalyst dates
[PULL] Latest Production to Develop
buid(yoroi-extension): buld scripts now compatible with Windows
Data inputs + P2S support
Ergo Connector Version bump 0.4.0
change icon "transactions"
…n-tx-fix Ergo Connector: Fix crash when signing a TX that mints new assets
Ledger wallet Catalyst voting registration support
# Conflicts: # packages/yoroi-extension/package-lock.json
UI updates for hardware wallet Catalyst registration
…ic than targeting `strong` property in all `g` tags
Tab icons css tiny fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the commits on my end at least. Those fixes resolving the issues are in here too so there should be no issue with the P2S/0.13.* sigma-rust updates.
Last prod:
4.5.5
https://github.com/Emurgo/yoroi-frontend/releases/tag/4.5.5
Main includes after last prod
Full PR diff since last prod