Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly / 4.5.5001 #2179

Merged
merged 154 commits into from
Jun 16, 2021
Merged

Nightly / 4.5.5001 #2179

merged 154 commits into from
Jun 16, 2021

Conversation

vsubhuman
Copy link
Contributor

Last prod: 4.5.5

https://github.com/Emurgo/yoroi-frontend/releases/tag/4.5.5

Main includes after last prod

  1. Hardware wallets support for Catalyst
  2. Ergo p2s and data-inputs, plus latest fixes, plus migration to sigma-rust 13.3

Full PR diff since last prod

rooooooooob and others added 30 commits May 3, 2021 22:18
P2S outputs supported
P2S inputs do not seem to work - more testing is needed.
Yoroi signs them without returning any errors, but when submitted to the
network they are not accepted.
We must use the inputs given to us as boxes to sign as even if we arent
directly signing them (P2S inputs) they need to be included in the tx
signing in sigma-rust. P2S inputs weren't found in the user's UTXOs so
they were silently filtered from the signing process unintentionally.

We will still need to update this later to get the keys in the same way
somehow or find a different way for the cases where it's a UTXO we'd
have control to sign over but it hasn't yet been put in our DB (e.g.
pending txs which was the reason why we changed UnsignedInputs to
include the full data in the first place)
Check delegation status and display a warning if the wallet hasn't delegated
Trezor wallet Catalyst voting registration support
Changed nightly build action to use `nightly` branch
[quickfix] Release/4.5.1 Catalyst dates
[PULL] Latest Production to Develop
buid(yoroi-extension): buld scripts now compatible with Windows
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman self-assigned this Jun 16, 2021
@vsubhuman vsubhuman changed the title Nightly / 4.5.5.1 Nightly / 4.5.5001 Jun 16, 2021
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman
Copy link
Contributor Author

@vsubhuman vsubhuman merged commit 46084cc into nightly Jun 16, 2021
@vsubhuman vsubhuman deleted the release/nightly/4.5.5.1 branch June 16, 2021 22:29
Copy link
Contributor

@rooooooooob rooooooooob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the commits on my end at least. Those fixes resolving the issues are in here too so there should be no issue with the P2S/0.13.* sigma-rust updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants