Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Version 1.1 for Theme Feature (based on Sebastien Theme Code) #284

Merged
merged 29 commits into from
Feb 23, 2019

Conversation

Mercurial
Copy link
Contributor

@Mercurial Mercurial commented Feb 7, 2019

  • I am converting the html.style CSS string into JSON string before saving into localStorage so it will be directly loadable by the ThemeManager via "variables" property

  • I am manipulating SVG directly from React as Component to dynamically generate theme preview. (Which seems to be causing eslint to fail)

So we can argue that maybe we can replace SVG with pure HTML Elements to generate preview

  • I also edited SVG code manually to be more responsive for aesthetic purposes

image

image

app/api/localStorage/index.js Outdated Show resolved Hide resolved
app/i18n/locales/en-US.json Outdated Show resolved Hide resolved
app/components/settings/categories/DisplaySettings.js Outdated Show resolved Hide resolved
app/themes/README.md Outdated Show resolved Hide resolved
app/themes/prebuilt/YoroiModern.js Show resolved Hide resolved
app/stores/toplevel/ProfileStore.js Show resolved Hide resolved
app/stores/toplevel/ProfileStore.js Show resolved Hide resolved
app/components/settings/categories/DisplaySettings.js Outdated Show resolved Hide resolved
app/components/settings/categories/DisplaySettings.scss Outdated Show resolved Hide resolved
app/assets/images/themes/yoroi-classic.inline.svg Outdated Show resolved Hide resolved
@Mercurial
Copy link
Contributor Author

Hi Guys!
I have completed all the requested change by Sebastien except the DOM direct read access to get current customized styles.

Let me know what you think
Thanks
Clark

themeVars: Object
};

export default class ThemeThumbnail extends Component<Props> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can clean this up by saving this as an svg file and then applying the color transformation using css style overrides in the Javascript. Maybe not a big deal though?

app/stores/toplevel/ProfileStore.js Outdated Show resolved Hide resolved
app/components/settings/categories/DisplaySettings.js Outdated Show resolved Hide resolved
@Mercurial
Copy link
Contributor Author

Mercurial commented Feb 11, 2019

by the way, there is a specific test that fails because it expect to interact with a second theme but since we disabled it does fail.

should we disable that test?

Just a heads-up
Clark

@SebastienGllmt
Copy link
Contributor

@Mercurial this is why I suggested you do "if not mainnet" instead of "if dev" that way the theme selection is still available during testing (this way the test passes)

@Mercurial
Copy link
Contributor Author

firefox tests seems to fail, not sure why though

@SebastienGllmt SebastienGllmt merged commit 3e5ccbc into Emurgo:develop Feb 23, 2019
@SebastienGllmt SebastienGllmt added spec-implementation Its has been approved by the triage process after a proposal was made UI/UX Makes a visual change labels Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-implementation Its has been approved by the triage process after a proposal was made UI/UX Makes a visual change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants