-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Version 1.1 for Theme Feature (based on Sebastien Theme Code) #284
[WIP] Version 1.1 for Theme Feature (based on Sebastien Theme Code) #284
Conversation
Pull request Merge
…ark/theme-feature
pull from emurgo/develop
…ark/theme-feature
…bles - Theme Thumbnail layout changes as requested . - Added Custom Theme reset warning message element.
Hi Guys! Let me know what you think |
themeVars: Object | ||
}; | ||
|
||
export default class ThemeThumbnail extends Component<Props> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can clean this up by saving this as an svg
file and then applying the color transformation using css style
overrides in the Javascript. Maybe not a big deal though?
by the way, there is a specific test that fails because it expect to interact with a second theme but since we disabled it does fail. should we disable that test? Just a heads-up |
@Mercurial this is why I suggested you do "if not mainnet" instead of "if dev" that way the theme selection is still available during testing (this way the test passes) |
pull from emurgo
firefox tests seems to fail, not sure why though |
I am converting the html.style CSS string into JSON string before saving into localStorage so it will be directly loadable by the ThemeManager via "variables" property
I am manipulating SVG directly from React as Component to dynamically generate theme preview. (Which seems to be causing eslint to fail)
So we can argue that maybe we can replace SVG with pure HTML Elements to generate preview