This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Prevent unexpected fields at the root of addresspaace etc failing the controller loop #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resspace, address and message from causing the controller loops to fail We were already using @JsonIgnoreProperties(ignoreUnknown = true) at the root of some IoT objects. This seemed to the least unobtrustive change. Added supporting tests.
lulf
approved these changes
Jul 3, 2020
|
@kornys this changes adds new system tests. |
|
@enmasse-ci run tests testcase=CustomResourceDefinitionAddressSpacesTest,CustomResourceDefinitionAddressesTest |
✔️ Test Summary ✔️TEST_PROFILE: pr |
|
@enmasse-ci run tests profile=isolated |
|
@k-wall could you please also add acceptance profile for this new test? |
|
❗ Build Failed ❗ |
|
@enmasse-ci run tests profile=isolated |
✔️ Test Summary ✔️TEST_PROFILE: isolated |
kornys
approved these changes
Jul 4, 2020
lulf
approved these changes
Jul 4, 2020
k-wall
added a commit
that referenced
this pull request
Jul 4, 2020
… controller loop (#4885) * Fix #4873: Prevent unexpected fields at the root of addresspace, address and message from causing the controller loops to fail We were already using @JsonIgnoreProperties(ignoreUnknown = true) at the root of some IoT objects. This seemed to the least unobtrustive change. Added supporting tests. * Add tags and change log (cherry picked from commit 9032ffb)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Prevent unexpected fields at the root of addresspaace, address and message from causing the controller loops to fail
We were already using
@JsonIgnoreProperties(ignoreUnknown = true)at the root of some IoT objects. This seemed to the least unobtrusive change.Added supporting tests.
Checklist
./documentation/design