added PersonName support to Value

[jmlaka]

Hello Eduardo,
I don't know if this would be useful but I needed to handle Dicom PN.
It only uses borrowed values and family, given names are not optional but mandatory.

Removed one typo from a previous Doc test

[Enet4]

Hello @jmlaka! Thank you for sending another contribution in.

A person name module can indeed be helpful for systems working such names semantically. More than once have I received cases in which the system didn't bother encoding each component properly.

However, it is important for the baseline implementation to be more flexible so as to avoid issues caused by less ordinary names that could hinder the process for bystanders. I wouldn't require ideographic/phonetic character groups to be supported in an initial phase, but I would not want the given and family names to be mandatory, especially when the standard imposes that any of them can be an empty string.

I invite you to continue working on this module so that it accepts person names in which any of the components may be empty. It might also be more usable to employ the builder pattern to construct a person name from scratch. Feel free to follow up if you have any questions or could use some guidance.

Other minor concerns inline with the code.

[jmlaka]

Please see

[Enet4]

I took the liberty of doing some final touches on this pull request. A summary:

• extend and adjust documentation and tests (to also include doctests and cover the person name builder)
• make PersonNameBuilder non-consuming
• add From<PersonNameBuilder> and From<&mut PersonNameBuilder> impls to PersonName
• rename PersonName::from_slice to PersonName::from_str
• rename DicomValue::as_person_name to DicomValue::to_person_name for consistency with the rest of the API

In any case, the module seems robust and well constructed. @jmlaka I am likely to merge this soon, but feel free to look over the extra commits in case you have any concerns or questions.

[jmlaka]

Thanks for your insights @Enet4 ! Everything is fine with me.

[Enet4]

Thank you!