Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add items helper #263

Merged
merged 3 commits into from
Jul 9, 2022
Merged

[core] Add items helper #263

merged 3 commits into from
Jul 9, 2022

Conversation

ingwinlu
Copy link
Contributor

@ingwinlu ingwinlu commented Jul 6, 2022

Allows for easy access to sequential data for example when trying
to access data stored in CONTENT_SEQUENCE tags commonly used in
SR files.

@ingwinlu
Add to_items helper
5c97781 
Allows for easy access to sequential data for example when trying
to access data stored in CONTENT_SEQUENCE tags commonly used in
SR files.
Enet4
Enet4 requested changes Jul 6, 2022
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice suggestion! We can bring it in after addressing the concerns inline.

core/src/header.rs Outdated Show resolved Hide resolved
core/src/header.rs Outdated Show resolved Hide resolved
ingwinlu and others added 2 commits July 6, 2022 21:18
@ingwinlu @Enet4
Update core/src/header.rs
2ee9741 
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
@ingwinlu
Rename method to comply with C-CONV
490fd55
@ingwinlu
Copy link
Contributor Author

ingwinlu commented Jul 6, 2022

adjusted the helper to be called "items"

@ingwinlu ingwinlu changed the title Add to_items helper Add items helper Jul 8, 2022
Enet4
Enet4 approved these changes Jul 9, 2022
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, all is in order. Thank you!

@Enet4 Enet4 merged commit e527731 into Enet4:master Jul 9, 2022
@ingwinlu ingwinlu deleted the core/feature/add-dataelement-to-items-helper branch July 10, 2022 05:25
@Enet4 Enet4 changed the title Add items helper [core] Add items helper Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ingwinlu @Enet4