[encoding] Extend TextCodec with decode_to and encode_to #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[breaking change] - encode_to pushes encoded string into an existing Vec<u8> - decode_to pushes decoded string into an existing String - provide default implementations for `decode` and `encode` based on `decode_to` and `encode_to`
in places where it can draw more benefits by avoiding allocations
in places where it can draw more benefits by avoiding allocations
Enet4
added
enhancement
breaking change
Enet4
changed the title
|
I will put this on hold until attempts are made to integrate with new text encoding libraries. |
|
Closing because I'm not sure this is the right direction for text encoding/decoding, and it's gone far behind by other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
TextCodectrait to also haveencode_toanddecode_tomethods, which take a heap allocated buffer value instead of returning a new one. This makes it possible to reduce the number of allocations needed in some cases.It is a breaking change because the trait is not sealed and implementations are required to provide definitions for these new methods.