Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[object] Make it possible to mutate FileMetaTable in FileDicomObject #280

Merged
merged 3 commits into from
Oct 2, 2022
Merged

[object] Make it possible to mutate FileMetaTable in FileDicomObject #280

merged 3 commits into from
Oct 2, 2022

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Sep 22, 2022 •
edited

  • Add new methods to manipulate FileMetaTable and refactor some of the implementation
  • Add FileDicomObject::meta_mut
  • Deprecate InMemDicomObject::meta

@Enet4
[object] Add manipulation methods to FileMetaTable
ba63475 
- add `update_information_group_length`
- refactor calculation of file meta information group length
  into private method
- add `set_transfer_syntax`
- document `from_reader`
@Enet4
[object] Add FileDicomObject::meta_mut
06be055
@Enet4
[object] Deprecate InMemDicomObject::meta
37acbee 
- not useful, always returned None
@Enet4 Enet4 added enhancement A-lib Area: library labels Sep 22, 2022
@Enet4 Enet4 merged commit 13cd138 into master Oct 2, 2022
@Enet4 Enet4 deleted the imp/object/meta_mut branch October 2, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-lib Area: library enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Enet4