Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ul] Improve association robustness and expressiveness #291

Merged
merged 8 commits into from
Oct 9, 2022
Merged

[ul] Improve association robustness and expressiveness #291

merged 8 commits into from
Oct 9, 2022

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Oct 7, 2022

  • Sanitize transfer syntax and abstract syntax UIDs
  • impl Display for various reason/source types in pdu
  • Include association source in association rejection error message
  • Add strict option for client and server associations
  • Add getter method client_ae_title() for server associations

@Enet4
[ul] add Display impls for pdu reason types
c7ba358
@Enet4
[ul] improve error message on association rejected
51f80a0 
- include rejection source from server
@Enet4
[ul] Sanitize UIDs in association negotiation
ebbd93e 
- add utility module uid
- trim null characters from UIDs in client and server association
- update storescu association test to use raw UIDs in SCU
@Enet4
[ul] extend server association properties
12edf95 
- add `strict` property as a server option
- add `client_ae_title` to server association
   - so as to know the remote node AE title
@Enet4
[ul] add strict property as a client option
12a3ef2
@Enet4 Enet4 added bug This is a bug enhancement A-lib Area: library labels Oct 7, 2022
@Enet4
[ul] elide lifetime in uid::trim_uid
b607dc9
@Enet4
[ul] fix strict option
7c6e38a 
- apply it to all PDU reading
@Enet4
[ul] Add robustness to trim_uid
dff9c7d 
- trim also trailing whitespace,
  which may happen in some DICOM impls
@Enet4 Enet4 merged commit 8baedeb into master Oct 9, 2022
@Enet4 Enet4 deleted the imp/ul/association-sanitize branch October 23, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-lib Area: library bug This is a bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Enet4