Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- fix person_name whitespace trim #299

Merged
merged 1 commit into from
Oct 23, 2022
Merged

- fix person_name whitespace trim #299

merged 1 commit into from
Oct 23, 2022

Conversation

jmlaka
Copy link
Contributor

@jmlaka jmlaka commented Oct 22, 2022

Building PersonName from slice requires whitespace trimming

@Enet4 Enet4 self-assigned this Oct 22, 2022
@Enet4 Enet4 added bug This is a bug A-lib Area: library labels Oct 22, 2022
Enet4
Enet4 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this change is sound and now covered! Thank you @jmlaka. 👍

@Enet4 Enet4 merged commit c584ef9 into Enet4:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees

@Enet4 Enet4

Labels
A-lib Area: library bug This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmlaka @Enet4