Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- replace deprecated chrono calls #310

Merged
merged 6 commits into from
Dec 10, 2022
Merged

- replace deprecated chrono calls #310

merged 6 commits into from
Dec 10, 2022

Conversation

jmlaka
Copy link
Contributor

@jmlaka jmlaka commented Nov 22, 2022

Replaces all chrono calls inside dicom::core:: to be deprecated in chrono 0.4.23
One change in dump crate

Leaves parser::stateful::decode::StatefulDecoder::new unchanged

@Enet4 Enet4 self-requested a review November 29, 2022 22:30
@Enet4 Enet4 added chore For keeping the project tidy A-lib Area: library labels Dec 10, 2022
Enet4
Enet4 reviewed Dec 10, 2022
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Some of the changes just become less readable, but I suppose the latest changes to the API intend to favour explicit error handling.

There were two other lines still using FixedOffset::east, but I took the liberty of updating the two here.

Enet4
Enet4 approved these changes Dec 10, 2022
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be in order now. Thank you. 👍

@Enet4 Enet4 merged commit 5483672 into Enet4:master Dec 10, 2022
@jmlaka jmlaka deleted the fix_chrono branch December 20, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
A-lib Area: library chore For keeping the project tidy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmlaka @Enet4