Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cargo features from chrono #356

Merged
merged 2 commits into from Jun 6, 2023
Merged

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Jun 5, 2023

This removes some default Cargo features from dicom-core dependency chrono. oldtime is unused and results in a false alarm vulnerability report. clock and wasmbind is not used by the project itself, but can be added back by dependents if they wish.

This should be a very minor breaking change.

- oldtime is unused and vulnerable
- clock and wasmbind is unused by the project itself,
  but may be added back by dependents
@Enet4 Enet4 added breaking change Hint that this may require a major version bump on release C-core Crate: dicom-core labels Jun 5, 2023
@Enet4 Enet4 added the C-parser Crate: dicom-parser label Jun 6, 2023
@Enet4 Enet4 merged commit fd02d79 into master Jun 6, 2023
4 checks passed
@Enet4 Enet4 deleted the change/core/chrono-default-features branch June 6, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Hint that this may require a major version bump on release C-core Crate: dicom-core C-parser Crate: dicom-parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant