InMemDicomObject Length::UNDEFINED after modify #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Length::UNDEFINED after modification - to it's inner entries value
Enet4
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Thank you for working on this.
Could you adjust some of these methods so that the length is not reset when no changes were truly made? Not that it's a huge problem, but it feels surprising for a method representing an operation as simple as removing an attribute to return an error and still make changes to the underlying object. I left some examples, it should not be hard to do the same for the other methods.
Enet4
reviewed
Jun 12, 2023
|
Right, sorry, did not notice.
po 12. 6. 2023 o 10:54 Eduardo Pinho ***@***.***> napísal(a):
… ***@***.**** commented on this pull request.
------------------------------
In object/src/mem.rs
<#364 (comment)>:
> @@ -728,8 +745,8 @@ where
let vr = e.vr();
// replace element
*e = DataElement::empty(tag, vr);
+ self.len = Length::UNDEFINED;
If I see this correctly, actions SetStr, Set, and the various Push* might
also modify data without calling put (see e.g. line 811), so we'd also
need some length resets in apply_push_*_impl and apply_change_value_impl.
—
Reply to this email directly, view it on GitHub
<#364 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARWGC3H24Z4TWIM5VOB3DDDXK3KMJANCNFSM6AAAAAAZCJZLGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Juraj Mláka
|
|
I just removed some duplicate code. The methods you mentioned did not need changes, as they internally call |
|
Still wrong :) Will be back |
Enet4
reviewed
Jun 14, 2023
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
Enet4
requested changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an
InMemDicomObjectcan have a certain definedLengthafter parsing dicom data,it is necessary to reset or recalculate this Length after calling any methods that modify
the object's inner entries value e.g.
.put().remove_element()...The Length is set to
Length::UNDEFINEDas recalculating it might be expensive.